Browse Source

improve pull request explanation

master
poikilos 6 years ago
committed by Jacob Gustafson
parent
commit
7897db0bea
  1. 12
      webapp/views/pages/getting-started.ejs

12
webapp/views/pages/getting-started.ejs

@ -312,10 +312,10 @@ files in a mod like that may help.
<p>A public license allows you to change and rerelease the mod, <p>A public license allows you to change and rerelease the mod,
in addition to just being "open source." Many in addition to just being "open source." Many
mods are on GitHub, GitLab, or notabug.org to allow easy mods are on GitHub, GitLab, or notabug.org to allow easy
forking. Forking is when someone other than the original author forking. Forking is when someone other than the project owner
makes improvements or fixes (often forking implies keeping it separate makes improvements or fixes (often forking implies keeping it separate
and not having your changes pulled in to the author's version). If the and not having your changes pulled in to the project owner's version).
changes If the changes
are applicable to everyone, you would usually fork it by clicking "fork" are applicable to everyone, you would usually fork it by clicking "fork"
which allows you to download your own copy of the mod with "GitHub which allows you to download your own copy of the mod with "GitHub
Desktop" for GitHub on Windows or a public licensed program like "Git Desktop" for GitHub on Windows or a public licensed program like "Git
@ -325,7 +325,11 @@ GitHub Desktop), name the commit, click commit, then click push. Then
you can go back to the repository online where you got the mod and click you can go back to the repository online where you got the mod and click
"pull request" comparing across forks to the "head" from your "pull request" comparing across forks to the "head" from your
repository, allowing the owner to "accept" the request or comment on repository, allowing the owner to "accept" the request or comment on
changes you need to make or regretfully decline. If the owner declines, changes you need to make or regretfully decline. Usually pull requests
are preceeded by discussion, often at an issue on the issue tracker.
Unless you are fixing something, you likely will have to present
something the project owner already wants or is trivial but helpful.
If the owner declines,
you can always keep your repository and use and distribute your version you can always keep your repository and use and distribute your version
of the mod if the license allows that. In some cases, you can instead of the mod if the license allows that. In some cases, you can instead
just make a mod that overrides an existing mod--that would require just make a mod that overrides an existing mod--that would require

Loading…
Cancel
Save