From fb4da8e1e7eaf20173acc96aa41c5a22d2538e3d Mon Sep 17 00:00:00 2001 From: poikilos <7557867+poikilos@users.noreply.github.com> Date: Sun, 3 Apr 2016 23:05:53 -0400 Subject: [PATCH] additional comments --- archivedebug.py | 2 +- expertmmregressionsuite.py | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/archivedebug.py b/archivedebug.py index 40b4494..649ac91 100644 --- a/archivedebug.py +++ b/archivedebug.py @@ -7,7 +7,7 @@ if os.path.isdir(minetestinfo.get_var("profile_minetest_path")): debug_archived_folder_name = "debug_archived" debug_archived_folder_path = os.path.join(minetestinfo.get_var("profile_minetest_path"), debug_archived_folder_name) if os.path.isfile(debug_txt_path): - print("NOT YET IMPLEMENTED") + print("NOT YET IMPLEMENTED (backup is not implemented)") else: print("There is no '"+debug_txt_path+"'") if os.sep=="\\": diff --git a/expertmmregressionsuite.py b/expertmmregressionsuite.py index 73fe06a..1c70357 100644 --- a/expertmmregressionsuite.py +++ b/expertmmregressionsuite.py @@ -14,6 +14,8 @@ module_list.append("traceback") from expertmm import * +### THE FUNCTIONS ARE USED ON minetest-chunkymap AT THE BOTTOM OF THIS SCRIPT ### + #TODO: code checking such as: # * check for redefining member variable (missing "self.") [since python does not throw NameError on definition, only if used and not defined] # * check for signs in len params (such as where str(len(part1+part2)) should be str(len(part1))+part2 @@ -21,13 +23,15 @@ from expertmm import * # * check for use of os.dirname (should be os.path.dirname) # * mixing width with y (or height or z) and mixing height with x (or width) # PHP: -# * using '+' next to '"' in php seperated only by whitespace (probably meant concatenate operator '.') +# * using '+' next to doublequote or singlequote in php, adjacent or seperated only by whitespace (probably meant concatenate operator '.') +# * using empty function (problematic since empty($value) evaluates to true when $value is zero -- empty_really in expertmm can be used instead) # SHELL SCRIPT: # * don't use '*' inside quotes (fails) # * using HOME without preceding dollar sign # ECMAScript: # * use of e.clientX e.clientY where line contains neither + or - (should use some kind of modifiers for scroll and canvas position such as in get_relative_mouse_point method) + def view_traceback(): ex_type, ex, tb = sys.exc_info() print(str(ex_type))