From 9919ca00d588dcfe4235f275a3a6476a87c96014 Mon Sep 17 00:00:00 2001 From: poikilos <7557867+poikilos@users.noreply.github.com> Date: Fri, 20 Sep 2019 17:00:46 -0400 Subject: [PATCH] Fix Blender script bugs; conform to PEP8 --- .../blender/generate_Empty_at_each_vertex.py | 37 +++++--- .../blender/generate_lua_collisionbox.py | 92 +++++++++---------- 2 files changed, 66 insertions(+), 63 deletions(-) diff --git a/utilities/blender/generate_Empty_at_each_vertex.py b/utilities/blender/generate_Empty_at_each_vertex.py index ea94f10..a24233a 100644 --- a/utilities/blender/generate_Empty_at_each_vertex.py +++ b/utilities/blender/generate_Empty_at_each_vertex.py @@ -1,12 +1,13 @@ -print("How to use: paste into a Blender Text Editor panel, select object, Run Script") +print("How to use: paste into a Blender Text Editor panel, select" + " object, Run Script") y_up = True enable_minetest = True import bpy -#from mathutils import Matrix +# from mathutils import Matrix from mathutils import Vector -#from mathutils import Euler +# from mathutils import Euler class MessageBox(bpy.types.Operator): bl_idname = "message.messagebox" @@ -23,13 +24,14 @@ class MessageBox(bpy.types.Operator): return {'FINISHED'} def invoke(self, context, event): - return context.window_manager.invoke_props_dialog(self, width = 400) + return context.window_manager.invoke_props_dialog(self, + width=400) def draw(self, context): self.layout.label(self.message) self.layout.label("") - #col = self.layout.column(align = True) - #col.prop(context.scene, "my_string_prop") + # col = self.layout.column(align = True) + # col.prop(context.scene, "my_string_prop") ob1 = None @@ -49,9 +51,9 @@ if ob1 is None: else: loc1 = ob1.location - #loc1 = ob1.matrix_world.translation + # loc1 = ob1.matrix_world.translation - #see https://blender.stackexchange.com/questions/6139/how-to-iterate-through-all-vertices-of-an-object-that-contains-multiple-meshes + # See https://blender.stackexchange.com/questions/6139/how-to-iterate-through-all-vertices-of-an-object-that-contains-multiple-meshes mesh = ob1.data # print("mesh:" + str(mesh)) # print("hasattr(mesh, 'vertices'):" + str(hasattr(mesh, 'vertices')))] @@ -70,19 +72,26 @@ else: newNamePrefix = "Empty.from." + ob1.name i = 0 for vert in mesh.vertices: - newName = newNamePrefix + "." + str(i) + name = newNamePrefix + "." + str(i) # This matrix multiplication is NOT transitive. try: loc = wm @ vert.co except TypeError: loc = wm * vert.co # Blender <2.8 - bpy.ops.object.add(type = 'EMPTY', radius = .25, location = loc); - bpy.context.active_object.name = newName - # NOTE: add only returns {'FINISHED'} # See also vert.co.x (and y and z) + bpy.ops.object.add(type='EMPTY', radius=.25, location=loc); + bpy.context.active_object.name = name - # add_named doesn't work this way--how is unknown: - # bpy.ops.object.add_named(name = "Empty" + ob1.name, type = 'EMPTY', radius = .25, location = loc) + # Also consider sambler's answer at + # : + # new_obj = bpy.data.objects.new(name, None) # , 'EMPTY')?? + # new_obj.location = (x,y,z) + # bpy.context.scene.objects.link(new_obj) # add to scene + + # The add_named code below doesn't work: + # bpy.ops.object.add_named(name="Empty" + ob1.name, + # type='EMPTY', radius=.25, + # location=loc) i += 1 # bpy.ops.message.messagebox('INVOKE_DEFAULT', message = msg) diff --git a/utilities/blender/generate_lua_collisionbox.py b/utilities/blender/generate_lua_collisionbox.py index 44863b5..6a3b2ca 100644 --- a/utilities/blender/generate_lua_collisionbox.py +++ b/utilities/blender/generate_lua_collisionbox.py @@ -1,13 +1,14 @@ -print("How to use: paste into a Blender Text Editor panel, select object, Run Script") +print("How to use: paste into a Blender Text Editor panel, select" + " object, Run Script") y_up = True enable_minetest = False import bpy -#from mathutils import Matrix +# from mathutils import Matrix from mathutils import Vector -#from mathutils import Euler +# from mathutils import Euler ob1 = None try: @@ -32,13 +33,14 @@ class MessageBox(bpy.types.Operator): return {'FINISHED'} def invoke(self, context, event): - return context.window_manager.invoke_props_dialog(self, width = 400) + return context.window_manager.invoke_props_dialog(self, + width=400) def draw(self, context): self.layout.label(self.message) self.layout.label("") - #col = self.layout.column(align = True) - #col.prop(context.scene, "my_string_prop") + # col = self.layout.column(align = True) + # col.prop(context.scene, "my_string_prop") bpy.utils.register_class(MessageBox) @@ -56,32 +58,24 @@ if (mesh is not None) and (not hasattr(mesh, 'vertices')): msg = "Collision box for armatures cannot be calculated." bpy.ops.message.messagebox('INVOKE_DEFAULT', message = msg) else: - #print(str(thisO)) - #extents1 = ob1.dimensions.copy() - #if (extents1.x == 0.0) and (extents1.y == 0.0) and (extents1.z == 0.0) and (ob1.scale.x > 0.0): - #extents1.x = extents1.x / 10.0 - #extents1.y = extents1.y / 10.0 - #extents1.z = extents1.z / 10.0 + # extents1 = ob1.dimensions.copy() obj1Loc = ob1.location - #obj1Loc = ob1.matrix_world.translation - #print(str(extents1)) - #see https://blender.stackexchange.com/questions/8459/get-blender-x-y-z-and-bounding-box-with-script - #bbox_corners = [ob1.matrix_world * Vector(corner) for corner in ob1.bound_box] + # See https://blender.stackexchange.com/questions/8459/get-blender-x-y-z-and-bounding-box-with-script + # bbox_corners = [ob1.matrix_world * Vector(corner) for corner in ob1.bound_box] + # use ground as bottom (don't do this--it is not the Minetest way) + # if zMin < 0.0: + # yMax -= yMin + # yMin = 0.0 - #use ground as bottom - #if zMin < 0.0: - # yMax -= yMin - # yMin = 0.0 + print(" collisionbox = {{{:.2f}, {:.2f}, {:.2f}, {:.2f}, {:.2f}," + " {:.2f}}}".format(xMin, yMin, zMin, xMax, yMax, zMax)) - #print( - # " collisionbox = {{{:.2f}, {:.2f}, {:.2f}, {:.2f}, {:.2f}, {:.2f}}}".format(xMin, yMin, zMin, xMax, yMax, zMax) - #) - - #see https://blender.stackexchange.com/questions/6139/how-to-iterate-through-all-vertices-of-an-object-that-contains-multiple-meshes - #print("mesh:" + str(mesh)) - #print("hasattr(mesh, 'vertices'):" + str(hasattr(mesh, 'vertices')))] + # See https://blender.stackexchange.com/questions/6139/how-to-iterate-through-all-vertices-of-an-object-that-contains-multiple-meshes + # print("mesh:" + str(mesh)) + # print("hasattr(mesh, 'vertices'):" + # + str(hasattr(mesh, 'vertices')))] xMin = None if mesh is not None: xMin = None @@ -112,20 +106,13 @@ else: zMax = loc.z # print(str(extents1)) # print("--by vertices (raw):") - # print( - # " collisionbox = {{{:.2f}, {:.2f}, {:.2f}, {:.2f}, {:.2f}, {:.2f}}}".format(xMin, yMin, zMin, xMax, yMax, zMax) - #) - - # use ob1.matrix_world instead of incrementing location. - # xMax += ob1.location.x - # xMin += ob1.location.x - # yMax += ob1.location.y - # yMin += ob1.location.y - # zMax += ob1.location.z - # zMin += ob1.location.z + print(" collisionbox = {{{:.2f}, {:.2f}, {:.2f}, {:.2f}," + " {:.2f}, {:.2f}}}".format(xMin, yMin, zMin, xMax, yMax, + zMax)) + # Use ob1.matrix_world (above) instead of incrementing + # ob1.location.x, y, and z - # print("--by vertices:") newNamePrefix = "Empty.EDGE." + ob1.name i = 0 wm = ob1.matrix_world @@ -135,17 +122,21 @@ else: loc = mat @ vert.co # NOT transitive except TypeError: loc = mat * vert.co # Blender <2.8 - isFar = True + isFar = False if loc.x == xMax or loc.y == yMax or loc.z == zMax: isFar = True elif loc.x == xMin or loc.y == yMin or loc.z == zMin: isFar = True if isFar: - # result = bpy.ops.object.add(type = 'EMPTY', radius = .25, location = loc); + pass + # result = bpy.ops.object.add(type='EMPTY', radius=.25, + # location=loc); # NOTE: result is merely {'FINISHED'} - # print("{:.2f}, {:.2f}, {:.2f}".format(loc.x, loc.y, loc.z)) + # print("{:.2f}, {:.2f}, {:.2f}".format(loc.x, loc.y, + # loc.z)) - # bpy.ops.object.add_named(name = newName, type = 'EMPTY', radius = .25, location = loc) + bpy.ops.object.add_named(name=newName, type='EMPTY', + radius=.25, location=loc) i += 1 else: extents1 = ob1.scale.copy() @@ -161,7 +152,7 @@ else: zMax = obj1Loc.z + extents1.z / 2.0 msgSuffix = " (using Empty object's scale)" # print("--using empty object:") - #switch y and z for Minetest (y-up): + # switch y and z for Minetest (y-up): if enable_minetest: xMin /= 10.0 xMax /= 10.0 @@ -170,7 +161,8 @@ else: zMin /= 10.0 zMax /= 10.0 - msg = 'Size is not available. Make sure you have a mesh object selected.' + msg = ('Size is not available. Make sure you have a mesh object' + ' selected.') if xMin is not None: if y_up: @@ -180,13 +172,15 @@ else: tmp = yMax yMax = zMax zMax = tmp - msg = " collisionbox = {{{:.2f}, {:.2f}, {:.2f}, {:.2f}, {:.2f}, {:.2f}}}".format(xMin, yMin, zMin, xMax, yMax, zMax) + msg = (" collisionbox = {{{:.2f}, {:.2f}, {:.2f}, {:.2f}," + " {:.2f}, {:.2f}}}".format(xMin, yMin, zMin, xMax, yMax, + zMax)) msg += msgSuffix - if enable_minetest: - msg += " #*10" + # if enable_minetest: + # msg += " -- *10" print(msg) - bpy.ops.message.messagebox('INVOKE_DEFAULT', message = msg) + bpy.ops.message.messagebox('INVOKE_DEFAULT', message=msg) # Unregistering before user clicks the MessageBox will crash Blender! # bpy.utils.unregister_class(MessageBox)