Browse Source

Add backend functions for examining partial pre-patched file trees (patches to Minetest games in the form of files). Add related tests.

master
poikilos 7 months ago
parent
commit
0f3c0e38a5
  1. 258
      pyenliven/mtpatches.py
  2. 1
      tests/data/base-same/extra_file_to_ignore.txt
  3. 1
      tests/data/base-same/same_file.txt
  4. 2
      tests/data/base/unused/sub/has_file/another_file/used_but_not_shallowest.txt
  5. 1
      tests/data/base/unused/sub/has_file/shallowest_in_base.txt
  6. 1
      tests/data/head-same/same_file.txt
  7. 1
      tests/data/head/unused/shallower_file.txt
  8. 1
      tests/data/head/unused/sub/has_file/shallowest_in_base.txt
  9. 92
      tests/test_mtpatches.py

258
pyenliven/mtpatches.py

@ -0,0 +1,258 @@
import os
import platform
import shlex
import shutil
import sys
import subprocess
MODULE_DIR = os.path.dirname(os.path.realpath(__file__))
REPO_DIR = os.path.dirname(MODULE_DIR)
if __name__ == "__main__":
# Allow importing pyenliven if running within
sys.path.insert(0, REPO_DIR)
def echo0(*args, **kwargs):
print(*args, file=sys.stderr, **kwargs)
DIFF_CMD_PARTS = None
if platform.system() == "Windows":
try_diff = shutil.which("diff")
# ^ Requires Python 3.3 or later (not 2.7)
if try_diff is not None:
DIFF_CMD_PARTS = ["diff"]
else:
DIFF_CMD_PARTS = ["fc"]
else:
DIFF_CMD_PARTS = ["diff"]
def diff_only_head(base, head, rel=None, more_1char_args=None, depth=0):
"""Compare two directories or files.
Files not in head will not be checked!
Therefore recursion here differs from a recursive call to GNU diff
(diff -ru).
The base and head are both at depth 0 and must be considered the
root of the relative path.
Args:
base (str): Path to original code (file or folder).
head (str): Path to new code (file or folder).
more_1char_args (Union[str,list[str]], optional): args. Defaults
to "-wb", or if using Windows, then "/W" if diff is not
present in PATH (in that case, fc is used).
rel (str, optional): Leave as None. This will be set
automatically for recursion.
depth (int, optional): Leave as 0. This will be set
automatically for recursion.
Raises:
FileNotFoundError: If base does not exist (and depth is 0).
FileNotFoundError: If head does not exist (and depth is 0).
FileNotFoundError: If diff is not in PATH.
ValueError: If one of the paths is a folder but the other is a
file.
Returns:
list(dict): A list of differing files as info dicts, each with:
- 'rel': The path relative to head.
- 'new': True if not in base, otherwise False or not present.
- 'code': Return code (1 if file in head&base differ)
"""
diffs = []
if not DIFF_CMD_PARTS:
ok_commands = 'diff'
if platform.system() == "Windows":
ok_commands = ['fc', 'diff']
raise FileNotFoundError("There is no {} in your PATH."
"".format(ok_commands))
args_1char = None
is_binary = False
if more_1char_args is None:
if platform.system() == "Windows":
if not is_binary:
args_1char = ["/W"] # ignore whitespace
else:
args_1char = ["/B"] # binary comparison
else:
if not is_binary:
args_1char = ["-wb"]
# -b: ignore changes in the amount of whitespace
# -w: ignore all white space (better for code since
# "a=1" is same as "a == 1", otherwise tokenizing
# the specific language would be necessary)
# -a: --text treat all files as text and
# --strip-trailing-cr strip trailing carriage
# return
# -E, --ignore-tab-expansion
else:
if more_1char_args.startswith("-"):
if DIFF_CMD_PARTS[0].lower() == "fc":
raise ValueError(
"diff wasn't in your PATH so fc is being used,"
" but it only accepts options"
" starting with '/'"
" (got \"{}\")".format(more_1char_args)
)
if isinstance(more_1char_args, (list, tuple)):
args_1char = more_1char_args
else:
# allow string too (split if has space, otherwise convert
# to 1-long list still)
args_1char = more_1char_args.strip().split()
whats = [None, None]
if rel:
base_path = os.path.join(base, rel)
head_path = os.path.join(head, rel)
else:
base_path = base
head_path = head
paths = (base_path, head_path)
names = ("base", "head")
for i, path in enumerate(paths):
if not os.path.exists(path):
if depth == 0:
raise FileNotFoundError(
"{}: {}".format(names[i], path)
)
else:
if os.path.isdir(path):
whats[i] = "folder"
else:
whats[i] = "file"
if whats[0] is None:
whats[0] = whats[1]
if whats[1] is None:
whats[1] = whats[0]
# ^ These are here since FileNotFoundError *only* is on depth==0.
if whats[0] != whats[1]:
raise ValueError(
'cannot compare {}:"{}" to {}:"{}"'
''.format(whats[0], base_path, whats[1], head_path)
)
if "folder" in whats:
# if "r" not in more_1char_args:
# more_1char_args += "r"
# ^ Not necessary since recursion needs to be done in this code
# (See docstring).
for sub in os.listdir(head_path):
sub_rel = os.path.join(rel, sub) if rel else sub
diffs += diff_only_head(
base,
head,
rel=sub_rel,
more_1char_args=more_1char_args,
depth=depth+1,
)
else:
# echo0('base={}:"{}"'.format(whats[0], paths[0]))
# echo0('head={}:"{}"'.format(whats[1], paths[1]))
# file, so actually compare
if not os.path.isfile(base_path):
# echo0("^ not in base")
if os.path.isdir(base_path):
raise NotImplementedError('should not be dir: "{}"'
''.format(base_path))
# ^ Should have been handled in "if" case above.
return [{
'code': 1,
'rel': rel,
'new': True,
}]
# echo0("^ in base")
cmd_parts = DIFF_CMD_PARTS.copy()
# echo0("args_1char={}".format(args_1char))
if args_1char:
cmd_parts += args_1char
cmd_parts += [base_path, head_path]
# echo0("\n\n{}".format(shlex.join(cmd_parts)))
child = subprocess.Popen(cmd_parts, stdout=subprocess.PIPE)
streamdata = child.communicate()[0]
data = streamdata
if sys.version_info.major >= 3:
data = streamdata.decode(sys.stdout.encoding)
print(data)
rc = child.returncode
if rc == 0:
# echo0("^ files are the same")
return [] # Do not add any diff entry.
else:
pass
# echo0("^ files differ")
return [{
'code': rc,
'rel': rel,
}]
return diffs # folder, so return every sub's diff(s) ([] if None)
def get_shallowest_files_sub(root, rel=None, depth=0, log_level=0):
"""Get the shallowest folder relative to root that contains file(s).
Args:
root (str): The folder to check for files recursively.
rel (str, optional): Leave blank (set automatically during
recursion).
depth (int, optional): Leave as 0 (set automatically during
recursion).
Returns:
Union(str, None): Get the relative dir that contains file(s).
"""
if root is None:
raise ValueError("root is {}".format(root))
if rel and rel.startswith(os.path.sep):
raise ValueError(
"rel cannot start with '{}'"
" because that would override root (depth={})"
"".format(os.path.sep, depth)
)
parent = os.path.join(root, rel) if rel else root
for sub in os.listdir(parent):
sub_path = os.path.join(parent, sub)
if os.path.isfile(sub_path):
return rel
# ^ Check *all* subs first, in case dir is listed before file.
# The *parent* has file(s), so return parent
# (must check if file *before* recursion
# or deeper folder with file may be found):
for sub in os.listdir(parent):
sub_path = os.path.join(parent, sub)
if os.path.isfile(sub_path):
continue
sub_rel = os.path.join(rel, sub) if rel else sub
if log_level > 0:
echo0("\ndepth={}".format(depth))
echo0("root:{}".format(root))
echo0("+rel:{}".format(rel))
echo0("=parent:{}".format(parent))
echo0("sub={}".format(sub))
echo0("sub_rel={}".format(sub_rel))
found_path = get_shallowest_files_sub(
root,
rel=sub_rel,
depth=depth+1,
log_level=log_level,
)
if found_path:
return found_path
continue
return None
def main():
return 0
if __name__ == "__main__":
sys.exit(main())

1
tests/data/base-same/extra_file_to_ignore.txt

@ -0,0 +1 @@
This file is only in base and should be ignored by patch comparison.

1
tests/data/base-same/same_file.txt

@ -0,0 +1 @@
This file is the same in both.

2
tests/data/base/unused/sub/has_file/another_file/used_but_not_shallowest.txt

@ -0,0 +1,2 @@
This is another test file for get_shallowest_files_sub.
This file should *not* be in head, to test ignoring files in base that are not patched by head.

1
tests/data/base/unused/sub/has_file/shallowest_in_base.txt

@ -0,0 +1 @@
This is a test file for get_shallowest_files_sub

1
tests/data/head-same/same_file.txt

@ -0,0 +1 @@
This file is the same in both.

1
tests/data/head/unused/shallower_file.txt

@ -0,0 +1 @@
This file is not in base.

1
tests/data/head/unused/sub/has_file/shallowest_in_base.txt

@ -0,0 +1 @@
This line differs from the one in base.

92
tests/test_mtpatches.py

@ -0,0 +1,92 @@
import os
import sys
import unittest
TESTS_DIR = os.path.dirname(os.path.realpath(__file__))
REPO_DIR = os.path.dirname(TESTS_DIR)
TESTS_DATA_DIR = os.path.join(TESTS_DIR, "data")
if __name__ == "__main__":
# Allow it to run without pytest.
sys.path.insert(0, REPO_DIR)
from pyenliven.mtpatches import ( # noqa F402
get_shallowest_files_sub,
diff_only_head,
)
class TestMTPatches(unittest.TestCase):
def test_get_shallowest_files_sub(self):
sub = get_shallowest_files_sub(
os.path.join(TESTS_DATA_DIR, "base")
)
self.assertEqual(sub, os.path.join("unused", "sub", "has_file"))
# ^ should be "has_file" dir, since that contains
# "shallowest_in_base.txt"
def test_get_shallowest_files_not_in_sub(self):
sub = get_shallowest_files_sub(
os.path.join(TESTS_DATA_DIR, "base", "unused", "sub", "has_file"),
log_level=1,
)
self.assertEqual(sub, None)
# ^ should be "has_file" dir, since that contains
# "shallowest_in_base.txt"
def test_diff_only_head__different_file(self):
base = os.path.join(TESTS_DATA_DIR, "base", "unused", "sub")
head = os.path.join(TESTS_DATA_DIR, "head", "unused", "sub")
# ^ use deeper dir to skip new file in head/unused/
# (See test_diff_only_head__new_file for that).
diffs = diff_only_head(
base,
head,
)
self.assertEqual(
diffs,
[
{
'rel': os.path.join("has_file", "shallowest_in_base.txt"),
'code': 1,
},
]
)
def test_diff_only_head__new_file(self):
base = os.path.join(TESTS_DATA_DIR, "base")
head = os.path.join(TESTS_DATA_DIR, "head")
diffs = diff_only_head(
base,
head,
)
self.assertEqual(
diffs,
[
{
'rel': os.path.join("unused", "sub", "has_file",
"shallowest_in_base.txt"),
'code': 1,
},
{
'rel': os.path.join("unused", "shallower_file.txt"),
'code': 1,
'new': True,
},
]
)
def test_diff_only_head__same(self):
base = os.path.join(TESTS_DATA_DIR, "base-same")
head = os.path.join(TESTS_DATA_DIR, "head-same")
diffs = diff_only_head(
base,
head,
)
# Same except ignore extra_file_to_ignore.txt:
self.assertFalse(diffs) # assert same (ignoring base extra file(s))
if __name__ == "__main__":
unittest.main()
Loading…
Cancel
Save